Styling for notes

[lucascumsille]

Relevant issue(s)

Related to #7240 and #7243

What does this do?

Added styling to notes when visiting:

• Authority page
• Request page
• New request page

[garethrees]

I'll leave @gbp to look at the code on this one. Would be good to add screenshots for all pages where these notes apply (on the free and pro UIs) so I can +1 without needing to set it all up myself 🙏

[lucascumsille]

I'll leave @gbp to look at the code on this one. Would be good to add screenshots for all pages where these notes apply (on the free and pro UIs) so I can +1 without needing to set it all up myself 🙏

Sure no problem, @garethrees

WDTK theme

None

Pro

I just noticed that the element #request_header_text, has some styling. For what I can see is not being used anywhere else. Do you want me to get rid of it?

[lucascumsille]

One thing to notice @garethrees
On the request page, because I couldn't see the notes I took and added this fragment
<% unless @batch %> <% if @info_request.public_body.has_notes? %> <div id="request_header_text" class="request_header_text"> <%= render_notes(@info_request.public_body.notes) %> </div> <% end %> <% end %>
into the new.html.erb file so I can see the notes. I got rid of that after talking with @gbp, so he will will include a in a future commit.

[garethrees]

I just noticed that the element #request_header_text, has some styling. For what I can see is not being used anywhere else. Do you want me to get rid of it?

I don't think we want the blue notes rendering in the green box, so if you think that's what needs to happen, sure!

[garethrees]

Looks great to me!

Need to resolve the #request_header_text issue before merge, but happy to approve based on what's presented and leave the final signoff/merge to @gbp

[lucascumsille]

@garethrees I just created a PR on the alavetelitheme repo for the #request_header_text element
Let me know if there is a more straight forward way to handle this =)

[garethrees]

@garethrees I just created a PR on the alavetelitheme repo for the #request_header_text element Let me know if there is a more straight forward way to handle this =)

I don't know off hand; something for you and @gbp to figure out 🕵️ !

[gbp]

Happy with your changes here and in alaveteli theme. Nice one