Show incoming message attachments in admin #5334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noting to myself to remember to add a changelog entry |
* Hash style * Quote style * Brace padding * Line spacing * DSL Parenthesis (don't need them for select tag)
When handling data breaches we need to find the hexdigest of the attachment to ensure it gets purged from all caches / backups etc. Its quite hard to do this – even from the console – and any console commands are prone to error. Its easier to just show the associated attachments on the admin interface, along with some less user-friendly information that's useful for admin purposes.
mysociety-pusher
force-pushed
the
show-incoming-message-attachments-in-admin
branch
from
76bab0b to
392a2da
Compare
mysociety-pusher
deleted the
show-incoming-message-attachments-in-admin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
https://github.com/mysociety/sysadmin/issues/1169
What does this do?
FoiAttachments related to anIncomingMessageatAdminIncomingMessageController#edit.Why was this needed?
When handling data breaches we need to find the hexdigest of the
attachment to ensure it gets purged from all caches / backups etc.
Its quite hard to do this – even from the console – and any console
commands are prone to error. Its easier to just show the associated
attachments on the admin interface, along with some less user-friendly
information that's useful for admin purposes.
It turned out it was easier to add this than explain in our internal guide
how to find the
hexdigestof a particular attachment through the railsconsole.
This might also be a nice point at which to link to individual attachments as part of #1005.
Implementation notes
Screenshots
Notes to reviewer