Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Postgres collation support check #3724

Closed
wants to merge 2 commits into from

Conversation

lizconlan
Copy link

Adds a check to for whether the current database encoding is compatible with the requested named collation when asking whether it is available for use.

Closes #3683

@lizconlan lizconlan force-pushed the 3683-postgres-collations branch from 1d8f2a9 to 15537e2 Compare February 7, 2017 15:32
@coveralls
Copy link

coveralls commented Feb 7, 2017

Coverage Status

Coverage decreased (-0.009%) to 92.967% when pulling 1d8f2a9 on 3683-postgres-collations into 857ee1c on develop.

@coveralls
Copy link

coveralls commented Feb 7, 2017

Coverage Status

Coverage decreased (-0.009%) to 92.967% when pulling 15537e2 on 3683-postgres-collations into 857ee1c on develop.

Copy link
Member

@garethrees garethrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good – great find!

I've pushed a couple of super minor fixups just for neatness.

Main thing was just making filter_collations a little clearer by explicitly passing the same arguments as the intended SQL.

@garethrees
Copy link
Member

Also, changelog plz! 👍

@lizconlan
Copy link
Author

Main thing was just making filter_collations a little clearer by explicitly passing the same arguments as the intended SQL.

Cheers, wasn't entirely happy with that tbh 👍

@lizconlan lizconlan force-pushed the 3683-postgres-collations branch from 0d8ab80 to 89674bd Compare February 8, 2017 18:06
@coveralls
Copy link

coveralls commented Feb 8, 2017

Coverage Status

Coverage increased (+0.03%) to 93.002% when pulling 0d8ab80 on 3683-postgres-collations into 857ee1c on develop.

@coveralls
Copy link

coveralls commented Feb 8, 2017

Coverage Status

Coverage increased (+0.01%) to 92.97% when pulling d405806 on 3683-postgres-collations into 72c7d47 on develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 92.97% when pulling d405806 on 3683-postgres-collations into 72c7d47 on develop.

@coveralls
Copy link

coveralls commented Feb 8, 2017

Coverage Status

Coverage increased (+0.02%) to 92.98% when pulling d405806 on 3683-postgres-collations into 72c7d47 on develop.

@lizconlan lizconlan force-pushed the 3683-postgres-collations branch from d405806 to 081f434 Compare February 9, 2017 10:01
@coveralls
Copy link

coveralls commented Feb 9, 2017

Coverage Status

Coverage increased (+0.01%) to 92.97% when pulling 081f434 on 3683-postgres-collations into 72c7d47 on develop.

@lizconlan
Copy link
Author

merged as hotfix/0.26.0.9 and hotfix/0.27.0.4

@lizconlan lizconlan closed this Feb 13, 2017
@lizconlan lizconlan deleted the 3683-postgres-collations branch January 29, 2018 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants