-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Postgres collation support check #3724
Conversation
1d8f2a9
to
15537e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good – great find!
I've pushed a couple of super minor fixups just for neatness.
Main thing was just making filter_collations a little clearer by explicitly passing the same arguments as the intended SQL.
Also, changelog plz! 👍 |
Cheers, wasn't entirely happy with that tbh 👍 |
0d8ab80
to
89674bd
Compare
1 similar comment
d405806
to
081f434
Compare
merged as hotfix/0.26.0.9 and hotfix/0.27.0.4 |
Adds a check to for whether the current database encoding is compatible with the requested named collation when asking whether it is available for use.
Closes #3683