Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigned sidebar list of requests #3403

Merged
merged 2 commits into from
Aug 3, 2016

Conversation

wrightmartin
Copy link
Contributor

@wrightmartin wrightmartin commented Jul 25, 2016

This makes the similar requests sidebar on the request page a lot neater, but removing some of the information presented

Part of #3269

@coveralls
Copy link

coveralls commented Jul 25, 2016

Coverage Status

Coverage decreased (-0.01%) to 91.511% when pulling 97becea on redesign-similar-requests into 0360a5f on develop.

@garethrees
Copy link
Member

Much nicer. This also changes the results in the "related requests" results when someone is making a new request:

screen shot 2016-07-25 at 12 48 56

I don't think the extra context is particularly valuable there, other than maybe the date?

@wrightmartin
Copy link
Contributor Author

@garethrees yeah the date would be useful there - is there a way in the template to only display it in the typeahead search?

@garethrees
Copy link
Member

garethrees commented Jul 28, 2016

@garethrees yeah the date would be useful there - is there a way in the template to only display it in the typeahead search?

Made it optional via 40b2509 – may or may not need to add a class to it for the search ahead now that the template has been changed.

@coveralls
Copy link

coveralls commented Jul 28, 2016

Coverage Status

Coverage decreased (-0.01%) to 91.513% when pulling 40b2509 on redesign-similar-requests into 0360a5f on develop.

wrightmartin and others added 2 commits August 3, 2016 10:14
Also cleaned up:

- each instead of for
- line length
@mysociety-pusher mysociety-pusher force-pushed the redesign-similar-requests branch from 8065435 to 11863e2 Compare August 3, 2016 09:14
@mysociety-pusher mysociety-pusher merged commit 11863e2 into develop Aug 3, 2016
@mysociety-pusher mysociety-pusher deleted the redesign-similar-requests branch August 3, 2016 09:15
@coveralls
Copy link

coveralls commented Aug 3, 2016

Coverage Status

Coverage decreased (-0.01%) to 91.503% when pulling 11863e2 on redesign-similar-requests into e5f1bcb on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants