[#1505] Reword View Requests to Browse Requests in nav #1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once you click on 'Browse Requests", you see the text below it "View and search requests" - should this be changed to "Browse and search requests" ? |
| @@ -181,7 +181,7 @@ def list | |||
| end | |||
|
|
|||
| @filters = params.merge(:latest_status => @view) | |||
| @title = _("View and search requests") | |||
| @title = _("Browse and search requests") | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
|
Marked as |
garethrees
changed the title
mysociety-pusher
force-pushed
the
issues/1505-nav-browse-requests
branch
from
3b74b50 to
8ecec52
Compare
User testing highlighted that it was easy to mistake "View Requests" for a Facebook-style wall rather than the list of all requests. [1] [1] #1505
Also for "View and search requests" --> "Browse and search requests"
mysociety-pusher
force-pushed
the
issues/1505-nav-browse-requests
branch
from
8ecec52 to
ebb2b78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1505.
User testing highlighted that it was easy to mistake "View Requests" for
a Facebook-style wall rather than the list of all requests. [1]
I've added a flag to only make this change for WDTK because translations,
but I'm not sure how easy it would be to test that the change is good or not,
so I'm thinking we just roll with "browse"?
[1] #1505