Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of in-line admin page help tips related to the ability to hide individual attachments #7416

Closed
RichardTaylor opened this issue Nov 3, 2022 · 3 comments
Labels
easier-admin Make issues easier to resolve f:admin improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) x:uk

Comments

@RichardTaylor
Copy link

Suggestions:

  • Note saying the first? attachment, or one with type text/plain is in-fact the message body and not what would generally be considered an attachment.
    • Can the relevant attachment be marked "message body"?
  • Warning on the edit attachment page that changing the prominence of the attachment doesn't affect the visibility of the filename
    • Could go a step further and note file names are impacted by censor rules on requests as another related tip

We want to make things easy for new admins to understand.

[Sorry this is one of those tickets/ticket notes that arises from a great new feature being deployed]

@garethrees garethrees added x:uk improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) f:admin easier-admin Make issues easier to resolve labels Nov 4, 2022
mysociety-pusher pushed a commit that referenced this issue Nov 4, 2022
Make it clear which attachment is the main body part when viewing lists
of attachments associated with an incoming message.

A part of #7416.
@garethrees
Copy link
Member

Can the relevant attachment be marked "message body"?

Yep! #7417

Warning on the edit attachment page that changing the prominence of the attachment doesn't affect the visibility of the filename

It does hide it for those who can't view the attachment:

Screenshot 2022-11-04 at 09 48 56

So in this case (requester_only):

  • Admins can see the filename
  • The requester can see the filename
  • A different logged in user cannot see the filename
  • A non-logged in visitor cannot see the filename

Is there somewhere else we've missed the reducing prominence of filename?

Sorry this is one of those tickets/ticket notes that arises from a great new feature being deployed

No need to apologise! This is how software works! ☺️

@RichardTaylor
Copy link
Author

Is there somewhere else we've missed the reducing prominence of filename?

Closing pending an example of any filename related issue.

I suspect the issue would have been one of surprise related to "Admins can see the filename", and the difference in behaviour between this system and censor rules - censor rules do make material disappear even for admins

@garethrees
Copy link
Member

the difference in behaviour between this system and censor rules - censor rules do make material disappear even for admins

Ah, yeah, this is based on the "prominence" system, which does allow admins to view all content. I'd like to nudge the Censor Rules towards using prominence too (#5412 (comment)) so that it's all a bit more aligned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easier-admin Make issues easier to resolve f:admin improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) x:uk
Projects
None yet
Development

No branches or pull requests

2 participants