Notes set against a key do not render when key:value is present

[mdeuk]

On WhatDoTheyKnow, we're considering using the new generalised notes functionality to display messaging on requests, e.g. where a generic event has occurred that effects multiple requests, or where a right to be forgotten indication has arrived from a search engine.

The best way for us to do this, would be to present both a key (e.g. rtbf) and a value (e.g. GDPR/SE/20220910-1) so that we can tie our internal records together.

It is possible to render a note on a request if a key is presented but if key and value are presented, a note linked to the key tag doesn't render on a request.

How to reproduce

1. Create a new request in a test authority
2. If one doesn't already exist, create a new note linked to a tag (e.g. rtbf)
3. Add the tag to the request via /admin, and note that on the request view, the tag is now present.
4. Amend the tag on the request to key:value format, e.g. rtbf:test.
5. Refresh the public view of the request, and note the tag is no longer rendered.

Expected behaviour

Note should display wherever the tag matches a key that has a note assigned.

Actual behaviour

Adding the value to the tag removes the note.

Reproducibility

I have tested this on WDTK requests 651067 and 896135, using note 8296. The former is embargoed, the latter is not. I used note 8296, setup against tag rtbf.

The issue is always reproducible; it is possible to reverse it by removing :value from the tag, but re-adding it will cause the issue to re-appear. This does not appear to be related to a cache.

Curio

After a value is added to the tag on a request, the request still shows on /admin/tags at key level. E.g. if I tag a request in the format above, it will still show on the admin page for the rtbf tag (under requests).

[RichardTaylor]

We could work around this by adding tags of key to bodies with a key:value tag. This could be achieved via spreadsheet wrangling and the csv upload feature.

A tweak in the code would be preferable though.

[RichardTaylor]

This could be achieved via spreadsheet wrangling and the csv upload feature.

That doesn't help for newly added tags, we'd need to remember to add both key and key:value so a code tweak is certainly the best approach.

[HelenWDTK]

This issue has been automatically closed due to a lack of discussion or resolution for over 12 months.
Should we decide to revisit this issue in the future, it can be reopened.