You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During the first manual transparency report we tried to tally the reasons which requests were hidden. In doing so we noticed that when requests have their prominence changed through the "Edit metadata" form no :reason param is recorded in the InfoRequestEvent. See mysociety/whatdotheyknow-theme#922 (comment).
To create a better audit trail when editing prominence in this way we could check whether the :prominence attribute was changed, and if so, redirect to an interstitial where a prominence reason is requested. This can then get added to the edit event that gets created.
EDIT: An extra form field reveal is a better approach #6790 (comment).
The text was updated successfully, but these errors were encountered:
A subtlety here is that when we record the reason through the "hide and notify" action it's set to a request status ("not_foi" or "vexatious") rather than free text. Might want to use some sort of canned reasons a la #6487.
garethrees
changed the title
Record prominence reason when editing through "Edit metadata"
Record prominence reason on the event when editing through "Edit metadata"
May 20, 2022
Adding an InfoRequest#prominence_reason is a better way of handling the form field (#6746). This issue now just exists to remember to record the form field's value when creating the event.
During the first manual transparency report we tried to tally the reasons which requests were hidden. In doing so we noticed that when requests have their prominence changed through the "Edit metadata" form no
:reason
param is recorded in theInfoRequestEvent
. See mysociety/whatdotheyknow-theme#922 (comment).To create a better audit trail when editing prominence in this way we could check whether the:prominence
attribute was changed, and if so, redirect to an interstitial where a prominence reason is requested. This can then get added to theedit
event that gets created.EDIT: An extra form field reveal is a better approach #6790 (comment).The text was updated successfully, but these errors were encountered: