Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record prominence reason on the event when editing through "Edit metadata" #6790

Closed
garethrees opened this issue Feb 16, 2022 · 5 comments
Closed

Comments

@garethrees
Copy link
Member

garethrees commented Feb 16, 2022

During the first manual transparency report we tried to tally the reasons which requests were hidden. In doing so we noticed that when requests have their prominence changed through the "Edit metadata" form no :reason param is recorded in the InfoRequestEvent. See mysociety/whatdotheyknow-theme#922 (comment).

To create a better audit trail when editing prominence in this way we could check whether the :prominence attribute was changed, and if so, redirect to an interstitial where a prominence reason is requested. This can then get added to the edit event that gets created.

EDIT: An extra form field reveal is a better approach #6790 (comment).

record-prominence-reason

@garethrees
Copy link
Member Author

A subtlety here is that when we record the reason through the "hide and notify" action it's set to a request status ("not_foi" or "vexatious") rather than free text. Might want to use some sort of canned reasons a la #6487.

@garethrees

This comment was marked as outdated.

@garethrees garethrees changed the title Record prominence reason when editing through "Edit metadata" Record prominence reason on the event when editing through "Edit metadata" May 20, 2022
@garethrees
Copy link
Member Author

Adding an InfoRequest#prominence_reason is a better way of handling the form field (#6746). This issue now just exists to remember to record the form field's value when creating the event.

@garethrees
Copy link
Member Author

Related to ensuring it's always recorded on change #7214.

@garethrees
Copy link
Member Author

Closing in favour of #6746 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant