Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to request page from pages noting an attachment has been hidden #6668

Closed
RichardTaylor opened this issue Nov 15, 2021 · 2 comments
Closed
Labels
f:redaction improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) stale Issues with no activity for 12 months transparent-administration x:uk

Comments

@RichardTaylor
Copy link

When non-logged in user visits a link to an attachment to a message which has now been hidden they get a message such as:

Message has been removed
This message has been hidden. [prominence reason]. A replacement response has been offered, and is expected. Please contact us if you have any questions. If you are the requester, then you may sign in to view the message.

An expert user could trim the URL back to /request/[requestID] and find the request page.

I'm wondering if a link could be provided to the request page so all those landing on such pages can be provided with a link to the request page in question.

Sometimes we have to hide messages containing lots of attachments due to an issue with one attachment, providing the link back to the thread might point readers in the direction of a replacement response, or uploaded attachments.

An example request on WhatDoTheyKnow where a message with attachments has been hidden is request 467592.

See also: Allow individual attachments to incoming messages to be hidden #1005

I think this feature would be useful even if we could hide individual attachments.

I've been wondering if we'd be in any way "leaking" URLs of hidden material by doing this, and I don't think we would be, as the current position is a "Message has been removed" page is generated irrespective of the attachment filename

https://www.whatdotheyknow.com/request/xxxxxxx/response/xxxxx/attach/xxx/any-text-can-be-written-here.pdf

@RichardTaylor
Copy link
Author

@garethrees notes:

The prominence reason is rendered on to the "message has been removed" page (even when navigating directly to the attached file), so that can be used to "redirect" to the replacement

This is a possible work around but it might be tricky to make it look right on both the request page and on the "message removed" page.

There's a ticket on formatting the prominence reason at

HTML in prominence reasons is not currently parsed as HTML so I don't think we can currently include a clickable link.

An un-clickable link isn't ideal.

Screenshot 2021-11-16 at 15 04 02

@garethrees garethrees added f:redaction improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) x:uk labels Nov 16, 2021
@HelenWDTK HelenWDTK added the stale Issues with no activity for 12 months label Nov 19, 2024
@HelenWDTK
Copy link
Contributor

This issue has been automatically closed due to a lack of discussion or resolution for over 12 months.
Should we decide to revisit this issue in the future, it can be reopened.

@HelenWDTK HelenWDTK closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f:redaction improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) stale Issues with no activity for 12 months transparent-administration x:uk
Projects
None yet
Development

No branches or pull requests

3 participants