Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better formatting of prominence reasons #3050

Closed
RichardTaylor opened this issue Feb 10, 2016 · 6 comments
Closed

Better formatting of prominence reasons #3050

RichardTaylor opened this issue Feb 10, 2016 · 6 comments
Labels
f:admin improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) stale Issues with no activity for 12 months t:design transparent-administration x:uk

Comments

@RichardTaylor
Copy link

When a message is hidden or made requestor_only a reason can be provided which is shown in place of the message.

Sometimes at WhatDoTheyKnow we use this field to publish the substance of a message in the place of a message we've had to hide from public view (because it contained personal information, or was potentially defamatory etc.). This, or other uses we make of the field, sometimes mean we try and put more than a single line of text in it.

Currently line breaks are removed when displaying the "Reason for prominence". Just allowing line breaks would provide a significant improvement on the appearance when this field has more content. Ideally perhaps blockquotes, links and paragraphs might be permitted and the way the reason is shown generally improved.

Example:
https://www.whatdotheyknow.com/request/prosecutions_by_dcal_ni#incoming-759073

While this is an issue, it affects relatively few requests so isn't very important. I'm tempted to mark it straight as "icebox" myself but will leave that to those who do the labelling/prioritising.

@crowbot crowbot removed the 1 - new label Feb 15, 2016
@RichardTaylor RichardTaylor changed the title Better formatting of prominance reasons Better formatting of prominence reasons Oct 17, 2016
@garethrees garethrees added f:admin improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) labels May 29, 2018
@garethrees
Copy link
Member

We now have Action Text available, so we could add it to the prominence_reasons attribute. We'd have to handle conversion back to plain text though.

Alternatively we could use a combination of simple_format and our own make_clickable from commonlib.

@gbp
Copy link
Member

gbp commented Nov 17, 2021

We'd have to handle conversion back to plain text though.

Maybe we should tackle #3420 and complete #3498 in some form?

@garethrees
Copy link
Member

Maybe we should tackle #3420 and complete #3498 in some form?

Don't completely disagree since I'm sure that's a factor here, but I think the text format hidden template is used when we fall back to plain text for zip downloads. I'm not sure how relevant it is in 2021, but it's typically good manners to provide a plain text version of HTML emails, so we'd probably want to consider that in some way irrespective of the approach we take here.

@garethrees
Copy link
Member

Related to #7314.

@RichardTaylor
Copy link
Author

Consider also the presentation of prominence reasons for attachments.

Sometimes a series of attachments will have been hidden with the same prominence reason.

[Sorry this is one of those tickets/ticket notes that arises from a new feature being deployed]

@HelenWDTK HelenWDTK added the stale Issues with no activity for 12 months label Nov 19, 2024
@HelenWDTK
Copy link
Contributor

This issue has been automatically closed due to a lack of discussion or resolution for over 12 months.
Should we decide to revisit this issue in the future, it can be reopened.

@HelenWDTK HelenWDTK closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f:admin improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) stale Issues with no activity for 12 months t:design transparent-administration x:uk
Projects
None yet
Development

No branches or pull requests

5 participants