Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrade from 1.8.7 to 1.9.3, some YAML data treated as binary #2411

Closed
crowbot opened this issue May 5, 2015 · 1 comment
Closed
Labels
bug Breaks expected functionality

Comments

@crowbot
Copy link
Member

crowbot commented May 5, 2015

This has caused errors on the macedonian site:

An Encoding::CompatibilityError occurred in user#signin:

incompatible character encodings: ASCII-8BIT and UTF-8
lib/i18n_fixes.rb:34:in `gsub'

When interpolating post_redirect.reason_params[:web] which has been serialised via YAML.

Seems like the issue described as "Deep deep YAML oddness" in https://www.zendesk.com/blog/upgrade-the-road-to-1-9/.
Looking at the code, I see we port the problematic method in question to ruby 1.9. Not sure if that's still needed.

@crowbot crowbot added bug Breaks expected functionality 4 - now labels May 5, 2015
@crowbot
Copy link
Member Author

crowbot commented May 7, 2015

Fixed in f75b1de

@crowbot crowbot closed this as completed May 7, 2015
@crowbot crowbot removed the 4 - now label May 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks expected functionality
Projects
None yet
Development

No branches or pull requests

1 participant