Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support for Ruby 1.8.7 #2048

Closed
7 tasks done
crowbot opened this issue Jan 5, 2015 · 10 comments
Closed
7 tasks done

Deprecate support for Ruby 1.8.7 #2048

crowbot opened this issue Jan 5, 2015 · 10 comments
Assignees

Comments

@crowbot
Copy link
Member

crowbot commented Jan 5, 2015

This will require (at least):

@crowbot
Copy link
Member Author

crowbot commented Jan 19, 2015

We should announce the deprecation in #2049

@garethrees
Copy link
Member

Wonder if Travelling Ruby will be any use here.

@crowbot
Copy link
Member Author

crowbot commented Mar 30, 2015

Sent out RFC on deprecating 1.8.7 https://groups.google.com/forum/#!topic/alaveteli-dev/AQ77FNN0JIU

@crowbot
Copy link
Member Author

crowbot commented Jun 22, 2015

I had a quick look at Travelling Ruby - one issue is "Traveling Ruby only supports a number of popular native extension gems, and only in some specific versions. You cannot use just any native extension gem."

@garethrees
Copy link
Member

Need to set 1.9 as the default ruby on the vagrant vms

@garethrees
Copy link
Member

@dracos
Copy link
Member

dracos commented Jul 27, 2015

This will fix #2683 according to the comment in

# TODO: When we no longer support Ruby 1.8, this can be done with /[[:alpha:]]/
validates_format_of :title, :with => /[ёЁа-яА-Яa-zA-Zà-üÀ-Ü]/iu,

@garethrees
Copy link
Member

# Ubuntu
update-alternatives --set ruby /usr/bin/ruby1.9.1

@garethrees
Copy link
Member

Looks like you need to update-alternatives for gem, but not the other other ruby-related binaries (e.g. irb, ri, rdoc, etc)

@garethrees
Copy link
Member

Don't merge after review – wait until major release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants