Extract stripping prominence_reason attribute

This is shared across all classes which include `MessageProminence` so can be extracted.
mysociety · Oct 7, 2022 · 1e1e401 · 1e1e401
1 parent 05849aa
commit 1e1e401
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 6 deletions.
diff --git a/app/models/concerns/message_prominence.rb b/app/models/concerns/message_prominence.rb
@@ -2,6 +2,7 @@ module MessageProminence
   extend ActiveSupport::Concern
 
   included do
+    strip_attributes only: [:prominence_reason]
     validates_inclusion_of :prominence, in: self.prominence_states
   end
 

diff --git a/app/models/foi_attachment.rb b/app/models/foi_attachment.rb
@@ -30,8 +30,6 @@
 class FoiAttachment < ApplicationRecord
   include MessageProminence
 
-  strip_attributes only: [:prominence_reason]
-
   belongs_to :incoming_message,
              :inverse_of => :foi_attachments
 

diff --git a/app/models/incoming_message.rb b/app/models/incoming_message.rb
@@ -41,8 +41,6 @@ class IncomingMessage < ApplicationRecord
   include CacheAttributesFromRawEmail
   include Taggable
 
-  strip_attributes only: [:prominence_reason]
-
   MAX_ATTACHMENT_TEXT_CLIPPED = 1000000 # 1Mb ish
 
   belongs_to :info_request,

diff --git a/app/models/outgoing_message.rb b/app/models/outgoing_message.rb
@@ -30,8 +30,6 @@ class OutgoingMessage < ApplicationRecord
   include LinkToHelper
   include Taggable
 
-  strip_attributes only: [:prominence_reason]
-
   STATUS_TYPES = %w(ready sent failed).freeze
   MESSAGE_TYPES = %w(initial_request followup).freeze
   WHAT_DOING_VALUES = %w(normal_sort