Fix BufferReader.read_strings mishandling feeding from buffer #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves an issue where the code would incorrectly read past the number of read characters that came from the network stream.
bretthoerner
added a commit
to getsentry/snuba
that referenced
this pull request
Feb 14, 2019
bretthoerner
added a commit
to getsentry/snuba
that referenced
this pull request
Feb 14, 2019
|
Great! Please fix flake8 to ensure that all tests are passed: |
bretthoerner
added a commit
to getsentry/snuba
that referenced
this pull request
Feb 14, 2019
* Use clickhouse-driver fork to fix read error. See: mymarilyn/clickhouse-driver#72 * Add note so we're not confused later.
|
@xzkostyan sorry for that, fixed. |
|
@mitsuhiko hi! I've bumped package version to 0.0.18. |
bretthoerner
added a commit
to getsentry/snuba
that referenced
this pull request
Feb 19, 2019
This includes Armin's fix: mymarilyn/clickhouse-driver#72
bretthoerner
added a commit
to getsentry/snuba
that referenced
this pull request
Feb 19, 2019
This includes Armin's fix: mymarilyn/clickhouse-driver#72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue where the code would incorrectly read past the number of read characters that came from the network stream.
We are seeing various problems reading from the network stream and I suspect this is caused by the buffered reader. We identified one case already where it would definitely read bad data which this pull request fixes.