[RFC] Do not require settings declaration if server support setting-as-string #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New settings are added frequently, more then clickhouse-driver has new release. The downside is that bool type detection now depends from the server, and it does not recognize 'yes'/'2', but recognize 'true'/'1', but I guess it is ok. (plus I'm not sure that it was a good idea to ignore case for char settings, if the string has more then 1 char)
|
P.S. Looks like travis-ci does not work anymore? (Anyway all tests passed for upstream clickhouse-server) |
xzkostyan
added a commit
that referenced
this pull request
Jun 18, 2020
azat
added a commit
to azat-ch/clickhouse-driver
that referenced
this pull request
Nov 25, 2020
azat
added a commit
to azat-ch/clickhouse-driver
that referenced
this pull request
Nov 25, 2020
Skipping unknown settings is not always the required behaviour, and most of the time you want the opposite - fail on unknown setting. Image that you pass some new setting, i.e. max_insert_threads, and you assume that the INSERT will be parallel, however due to you server was too old the setting is silently ignored. Refs: mymarilyn#142
azat
added a commit
to azat-ch/clickhouse-driver
that referenced
this pull request
Nov 25, 2020
Skipping unknown settings is not always the required behaviour, and most of the time you want the opposite - fail on unknown setting. Image that you pass some new setting, i.e. max_insert_threads, and you assume that the INSERT will be parallel, however due to you server was too old the setting is silently ignored. Refs: mymarilyn#142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New settings are added frequently, more then clickhouse-driver has new
release.
The downside is that bool type detection now depends from the server,
and it does not recognize 'yes'/'2', but recognize 'true'/'1', but I
guess it is ok.
(plus I'm not sure that it was a good idea to ignore case for char
settings, if the string has more then 1 char)
History of syncing settings with upstream: