Skip to content

Commit

Permalink
Set allow_suspicious_low_cardinality_types for LowCardinality tests
Browse files Browse the repository at this point in the history
This setting has been introduced in v19.9.2.4-stable (all previous tags
marked as -testing, so I think they should be skipped).

Refs: ClickHouse/ClickHouse@4819a34
Refs: ClickHouse/ClickHouse#5448
  • Loading branch information
azat committed Oct 12, 2019
1 parent bedbeec commit b3e4319
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
env:
- VERSION=19.8.3.8 # SimpleAggregateFunction
- VERSION=19.15.3.6 # latest
- VERSION=19.9.2.4 # allow_suspicious_low_cardinality_types
- VERSION=19.8.3.8 # SimpleAggregateFunction
- VERSION=19.3.3
- VERSION=18.12.17
- VERSION=18.12.13
Expand Down
7 changes: 7 additions & 0 deletions tests/columns/test_low_cardinality.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,3 +151,10 @@ def test_fixed_string(self):

inserted = self.client.execute(query)
self.assertEqual(inserted, data)

def create_table(self, columns, **kwargs):
# allow_suspicious_low_cardinality_types introduced in v19.9.2.4-stable
if self.client.connection.server_info.version_tuple() >= (19, 9, 2):
kwargs['allow_suspicious_low_cardinality_types'] = 1
return super(LowCardinalityTestCase, self).create_table(columns,
**kwargs)

0 comments on commit b3e4319

Please sign in to comment.