Send end-of-stream request to all active sessions before solar terminates #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behaviour is not spec'd out for EBT so I'm simply following the defined behaviour for classic replication streams.
When
solarreceives a termination signal, any active EBT session peers are sent an RPC message with both the stream and end/err flags set and a JSON body oftrue. Upon receiving such a request, asolarpeer will send one in response (this is probably unnecessary but seems like good practice nonetheless).Manyverse does not appear to implement this behaviour; no end-of-stream RPC message is received when terminating Manyverse during an active session (at least not that I can detect). I would much rather have explicit communication in this case.