Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#32): 🐛 only load config when needed and fixed relative path to support win 10 #34

Closed
wants to merge 1 commit into from

Conversation

Stormix
Copy link

@Stormix Stormix commented Feb 16, 2021

This PR fixed the following bug:


Describe the bug
This relates to #32 . Running the init command fails since the cli expects a configuration when instantiated.

To Reproduce
Steps to reproduce the behavior:

  1. install the library in a new project
  2. run the init command

Expected behavior
After installing the library, a user should be able to initialize a new migrations folder/configuration.


It also fixed issues on Windows 10, where process.env.PWD is not defined (more info here) and uses path.join() to concatenate paths instead of raw string concatenation.

@Stormix
Copy link
Author

Stormix commented Mar 3, 2021

@mycodeself

@mycodeself
Copy link
Owner

Hello, thank you for your PR and sorry for the delay.

Currently, we are running the cli creating a new instance of the CLI and executing it with ts-node as seen in the examples. I think this breaks this way of use, does it?

--

I have released a new version updating dependencies and adding your proposed changes using path.join()

@mycodeself mycodeself closed this Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants