Introduce Spring's AliasFor declaration in MapperScan #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenqimiao
changed the title
|
Can someone review this PR ？ |
|
Thanks for your contribution! Your suggestion is reasonable and correct!! But I have no plan that apply this PR at maintenance version up (e.g. 2.0.5, 2.0.6, ...) because this changes broke a current behavior. I will plan to merge this PR at next minor or major version up(e.g. 2.1.0, 3.0.0). P.S.
|
kazuki43zoo
added
the
no backward compatibility
|
LGTM |
|
@chenqimiao I've merged! thanks!! |
kazuki43zoo
added
polishing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Spring's
AliasFordeclaration inMapperScan, We only need to get all the attributes throughbasePackages, without checkingvalue, even if the user only fills invalue.Also this annotation
AliasForadds readability to some extent, I think this is a nice feature and hope you can consider introducing, looking forward to your reply.