Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have found the
XMLMapperBuilder
contains two points can be optimized.First: use method instead of parent variable
Its superclass is
BaseBuilder
which provide methodresolveAlias(alias)
to do this, may be can use method directly.Second: use lambda to lazy compute
The method
getStringAttribute(value, default)
returndefault
only whenvalue
isnull
.So when
value
is not null,default
will be ignored,By use lambda,
default
will be computed only whenvalue
isnull
.