Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the problem that when the jdbc type is Array and Array.free() is called, the log parameter printed by BaseJdbcLogger is null. #3163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smagical
Copy link

#3162 Fixed the problem that when the jdbc type is Array and Array.free() is called, the log parameter printed by BaseJdbcLogger is null.

@harawata
Copy link
Member

Thank you, @smagical .

Could you create a small demo project that reproduces the original problem you are experiencing?
I'm not sure how Array.free() is called and when it's called.
Here are some project templates and examples: https://github.com/harawata/mybatis-issues

@smagical
Copy link
Author

smagical commented May 18, 2024

demo
A very small problem, only affecting debugging

@harawata
Copy link
Member

Thank you, @smagical ,

I understand the problem.

In the BaseJdbcLogger#setColumn() method, it seems to be better to store processed string of each parameter in columnValues instead of the object itself.
Can you think of any negative side effect?

…s called, the log parameter printed by BaseJdbcLogger is null.
@smagical
Copy link
Author

This is a good idea, but I found another problem BaseJdbcLogger#getColumn() This method will cause problems. There is no way to return the original data. The same is true for my modification method, although I haven't found where yet. Call this method.

@harawata
Copy link
Member

I'm sorry about the slow response.

You can ignore getColumn().
I'm not sure if the method used.
And java.sql.Array is rarely used anyway.

@wuyb518
Copy link

wuyb518 commented Aug 15, 2024

We can directly use method ps.setObject(i, parameter, Types.ARRAY);, database driver has ability to handle java array object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants