-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self update for youtube-dl #119
Comments
Agreed, this can particularly frustrate usage via docker, as users pulling the latest image from dockerhub are limited to the version of youtube-dl explicitly installed by the current podsync Dockerfile (2020.01.24). A cron job used to regularly self-update youtube-dl could solve this problem, but it might also be worth considering the use of pip to install the latest version of youtube-dl at image build time -- the latter would probably better align with standard docker deployment methodologies, e.g.:
|
Can you guys give it a try? (you can download latest non-release binaries from here: https://github.com/mxpv/podsync/actions/runs/82314116) |
@mxpv Could you upload/tag a 'preview' or 'test' image to dockerhub containing the binary you'd like me to test? I only deploy podsync via docker, so testing the binary directly is problematic. |
Will add: #135 |
Not exactly self update, but at least update for those like me that use only the Docker version: Managed to work with current Docker version and latest youtube-dl, just added the following volume mapping to docker-compose.yml: - ./youtube-dl:/usr/bin/youtube-dl
Then downloaded youtube-dl from latest version on GitHub and it started to work. I can update youtube-dl manually now using docker image! |
Self update is implemented in 2.3.0.
|
I think can add additional cron job
@daily
for execution self update of youtube-dlThe text was updated successfully, but these errors were encountered: