Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx issue #938 #940

Merged
merged 3 commits into from
Apr 3, 2022
Merged

FIx issue #938 #940

merged 3 commits into from
Apr 3, 2022

Conversation

Skylion007
Copy link
Contributor

@Skylion007 Skylion007 commented Mar 30, 2022 •
edited
Loading

@mwouts
Copy link
Owner

mwouts commented Apr 1, 2022

Hi @Skylion007 , thank you for the PR.
At the moment I can't figure out why the pre-commit test is failing, I'll have a look soon.

@mwouts mwouts mentioned this pull request Apr 2, 2022
Merged
@mwouts
Copy link
Owner

mwouts commented Apr 2, 2022

The CI seems to have been fixed with #943 - @Skylion007, would you mind to rebase your fix ? Thanks!

@mwouts
Copy link
Owner

mwouts commented Apr 3, 2022

Thank you @Skylion007 !

@mwouts mwouts merged commit 2198b42 into mwouts:main Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skylion007 @mwouts