Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Haskell as a supported language. #909

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Conversation

codeweber
Copy link
Contributor

@codeweber codeweber commented Feb 2, 2022

Haskell has been added as a supported language. Example notebook has been added.

Tests executed:

  • pytest was run and mirror tests pass.
  • Package was built locally and installed. It is possible to pair a Jupyter notebook running a Haskell kernel with a script; basic functionality has been tested (e.g. opening and editing script, checking to see if changes are reflected in notebook and vice versa).

@mwouts
Copy link
Owner

mwouts commented Feb 2, 2022

Excellent! Thank you @codeweber for your contribution. I'll have a look very soon and if everything goes well I'll try to package a new release next week at most.

@mwouts
Copy link
Owner

mwouts commented Feb 2, 2022

To fix the pre-commit check on the CI, you will have to run

pip install pre-commit
pre-commit run --all

(see also https://jupytext.readthedocs.io/en/latest/developing.html)

This will cause a very minor change which should fix the CI:
image

Or even maybe you could just add the missing coma manually?

Thank you,

@codeweber
Copy link
Contributor Author

@mwouts thank you! I've committed a change with the required comma so that the pre-commit checks pass successfully.

@mwouts mwouts added this to the 1.13.7 milestone Feb 4, 2022
@mwouts mwouts merged commit 1b0cdf6 into mwouts:main Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants