Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter the text_representation metadata in the contents manager #903

Merged
merged 9 commits into from
Jan 11, 2022

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Jan 11, 2022

Fixes #900
And also #901

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #903 (cfc9e1c) into main (57d83aa) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #903      +/-   ##
==========================================
+ Coverage   99.04%   99.06%   +0.01%     
==========================================
  Files         115      116       +1     
  Lines       10721    10779      +58     
==========================================
+ Hits        10619    10678      +59     
+ Misses        102      101       -1     
Impacted Files Coverage Δ
jupytext/cli.py 95.87% <ø> (+0.18%) ⬆️
jupytext/contentsmanager.py 97.61% <100.00%> (ø)
jupytext/jupytext.py 98.40% <100.00%> (+0.02%) ⬆️
jupytext/version.py 100.00% <100.00%> (ø)
tests/test_cm_config.py 100.00% <100.00%> (ø)
tests/test_pre_commit_1_sync_with_config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d83aa...cfc9e1c. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jan 11, 2022

This pull request introduces 1 alert when merging 1365865 into 57d83aa - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

Module 'jupytext' is imported with both 'import' and 'import from'
@mwouts mwouts force-pushed the new_test_for_pre_commit_sync branch from a6b5a6c to cfc9e1c Compare January 11, 2022 08:02
@mwouts mwouts merged commit f8e8352 into main Jan 11, 2022
@mwouts mwouts deleted the new_test_for_pre_commit_sync branch January 11, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jupyterlab adds jupytext metadata, but then jupytext --sync removes it again
1 participant