Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for markdown-it-py v2.0 #885

Merged
merged 2 commits into from
Dec 4, 2021
Merged

Allow for markdown-it-py v2.0 #885

merged 2 commits into from
Dec 4, 2021

Conversation

chrisjsewell
Copy link
Contributor

This implements some internal changes, but won't affect jupytext
(see https://github.com/executablebooks/markdown-it-py/releases/tag/v2.0.0)

This implements some internal changes, but won't affect jupytext
(see https://github.com/executablebooks/markdown-it-py/releases/tag/v2.0.0)
@chrisjsewell
Copy link
Contributor Author

chrisjsewell commented Dec 3, 2021

Could also update environment.yml, although v2 is not on conda just yet

@mwouts mwouts added this to the 1.13.3 milestone Dec 3, 2021
@mwouts
Copy link
Owner

mwouts commented Dec 3, 2021

Hi @chrisjsewell , sure I can take this. You seem to still allow markdown-it-py~=1.0, is this intended? If so we could replicate what you did on the requirements.txt file to the environment.yaml one, don't you think so?

Also, do you want me to merge this now or should I wait for markdown-it-py==2.0 to reach conda?

@chrisjsewell
Copy link
Contributor Author

You seem to still allow markdown-it-py~=1.0, is this intended?

Yep, the changes from v1 -> v2 don't specifically impact jupytext functionality, so both can be used fine

@chrisjsewell
Copy link
Contributor Author

Also, do you want me to merge this now or should I wait for markdown-it-py==2.0 to reach conda?

updated environment.yaml, so yeh fine to merge now

@mwouts mwouts merged commit da3fcc3 into mwouts:main Dec 4, 2021
@mwouts
Copy link
Owner

mwouts commented Dec 4, 2021

Merged just now, thank you @chrisjsewell !

@mwouts
Copy link
Owner

mwouts commented Dec 12, 2021

Hi @chrisjsewell , maybe we should also update that line?

"markdown-it-py~=1.0",

And this other one (for the conda package)?

https://github.com/conda-forge/jupytext-feedstock/blob/6283a34bc51a63514b5bbb90955d31c159586a2e/recipe/meta.yaml#L32

If you confirm I can prepare a fix tomorrow.

@dotlambda
Copy link

Please update the version constraint in setup.py.

chrisjsewell added a commit to chrisjsewell/jupytext that referenced this pull request Feb 23, 2022
I already did this in mwouts#885, but missed out updating this file.

When is `requirements.txt` actually used, as opposed to `install_requires`?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants