Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that notebooks can be trusted (2) #826

Merged
merged 3 commits into from
Aug 31, 2021
Merged

Test that notebooks can be trusted (2) #826

merged 3 commits into from
Aug 31, 2021

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Jul 15, 2021

This PR adds a test that a simple notebook can be trusted #797 .

Most of the problem with notebooks that cannot be trusted comes from using Jupyter Lab in a version prior to 3.0.13, in which cell ids were not available, so we recommend using a newer version for developing.

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@94ac59d). Click here to learn what that means.
The diff coverage is 97.55%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #826   +/-   ##
=========================================
  Coverage          ?   99.10%           
=========================================
  Files             ?      106           
  Lines             ?    10321           
  Branches          ?        0           
=========================================
  Hits              ?    10229           
  Misses            ?       92           
  Partials          ?        0           
Impacted Files Coverage Δ
jupytext/reraise.py 25.00% <25.00%> (ø)
jupytext/kernels.py 92.85% <92.85%> (ø)
jupytext/pep8.py 95.58% <95.58%> (ø)
jupytext/cli.py 96.12% <96.07%> (ø)
jupytext/cell_reader.py 96.86% <96.49%> (ø)
jupytext/pandoc.py 96.61% <96.61%> (ø)
jupytext/cell_to_text.py 97.80% <97.16%> (ø)
jupytext/myst.py 97.19% <97.19%> (ø)
jupytext/config.py 97.28% <97.28%> (ø)
jupytext/contentsmanager.py 97.83% <97.70%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94ac59d...04b5281. Read the comment docs.

@mwouts mwouts merged commit efe9cb0 into master Aug 31, 2021
@mwouts mwouts deleted the trust_notebooks_2 branch August 31, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant