Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an explicit encoding="utf-8" in every call to open #774

Merged
merged 2 commits into from
May 1, 2021

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented May 1, 2021

Closes #770

@mwouts mwouts force-pushed the open_encoding_utf8 branch from 0c2cfab to eba0f41 Compare May 1, 2021 16:53
@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #774 (eba0f41) into master (be5f4aa) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #774   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         106      106           
  Lines       10032    10032           
=======================================
  Hits         9943     9943           
  Misses         89       89           
Impacted Files Coverage Δ
jupytext/contentsmanager.py 97.85% <ø> (ø)
jupytext/cli.py 96.13% <100.00%> (ø)
jupytext/config.py 97.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be5f4aa...eba0f41. Read the comment docs.

@mwouts mwouts merged commit e4f9623 into master May 1, 2021
@mwouts mwouts deleted the open_encoding_utf8 branch May 1, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position X: character maps to <undefined>
1 participant