-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encapsulate code cells with triple backticks with +1 backtick in Markdown #726
Conversation
FYI I changed my mind, and finally prefer to keep the parsing of the code cell, for a while at least, to provide backward compatibility. |
Heya yeh that looks good to me 👍 |
Codecov Report
@@ Coverage Diff @@
## master #726 +/- ##
==========================================
- Coverage 99.12% 99.12% -0.01%
==========================================
Files 95 97 +2
Lines 9502 9591 +89
==========================================
+ Hits 9419 9507 +88
- Misses 83 84 +1
Continue to review full report at Codecov.
|
@chrisjsewell you're too fast! You did not even leave me the time to ask 😆 So just to be sure you're also OK with the version bump on the MyST format (to 0.13)? Thanks! |
c4b5a4a
to
3cdd2dc
Compare
Indeed! The markdown code blocks with triple backticks that encapsulate a code cell with triple backticks in a string will become markdown code blocks with quadruple backticks, like in this test (look at line 784) jupytext/tests/test_read_simple_markdown.py Lines 768 to 785 in 1449249
|
This PR will close #712 .
@rsokl I am considering taking this opportunity to remove the parsing of Python strings inside code cells (since now the cell marker is non-ambiguous), but that may break some of your notebooks, cf. #419 . Do you have many of them?
Also @chrisjsewell I have not yet ported this to
md:myst
but I intend to do so before merging.