-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupytext depends on markdownitpy #601
Conversation
Codecov Report
@@ Coverage Diff @@
## master #601 +/- ##
==========================================
- Coverage 99.00% 98.97% -0.04%
==========================================
Files 90 90
Lines 8980 9000 +20
==========================================
+ Hits 8891 8908 +17
- Misses 89 92 +3
Continue to review full report at Codecov.
|
Yep that looks fine thanks. Two minor things: As you see in the CI, if you make a PR to master from an "internal" branch you get duplication of runs. To remove this we use:
I made #602, to also update the import error message and documentation |
Another FYI: Here's the # To use tox, see https://tox.readthedocs.io
# Simply pip or conda install tox
# If you use conda, you may also want to install tox-conda
# then run `tox` or `tox -- {pytest args}`
# To run in parallel using `tox -p` (this does not appear to work for this repo)
# To rebuild the tox environment, for example when dependencies change, use
# `tox -r`
# Note: if the following error is encountered: `ImportError while loading conftest`
# then then deleting compiled files has been found to fix it: `find . -name \*.pyc -delete`
[tox]
envlist = py{35,36,37,38}
[testenv:py{35,36,37,38}]
; recreate = false
deps = -rrequirements-dev.txt
commands = pytest {posargs}
[testenv:docs-{update,clean}]
deps = -rdocs/doc-requirements.txt
whitelist_externals = rm
commands =
clean: rm -rf docs/_build
sphinx-build {posargs} -nW --keep-going -b html docs/ docs/_build/html |
Thank you @chrisjsewell ! This is very helpful. I'll integrate this PR, as well as your update on the documentation and warnings, and open a follow-up issue to keep track of your multiple suggestions 😄 . |
0e2f1c7
to
883428d
Compare
Thanks @mwouts 😄 |
Well if everything goes well, it could come within one day or two... fingers crossed! |
A release candidate is available here:
|
awesome thanks 😄 |
This is an alternative to #599 which has the dependency on
markdown-it-py
only when Python >= 3.6.