-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create a logo for jupytext #423
Conversation
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
==========================================
- Coverage 98.93% 98.91% -0.03%
==========================================
Files 75 75
Lines 7608 7448 -160
==========================================
- Hits 7527 7367 -160
Misses 81 81
Continue to review full report at Codecov.
|
Maybe this can come with a quick note in the docs for what font the logo uses? Maybe that's unnecessary, but I've found stuff like that is helpful in order to avoid having to reverse-engineer the logo at some point in the future if need be... |
Thank you so much @rgbkrk ! In addition to the svg file, I'd like to
|
I don't know why but for some reason open source logo design is one of my favorite kinds of open source contributions to see :-) |
The font is Dank Mono. Happy to help. When you link in the readme you'll probably want to point directly at a full github URL pointing to master rather than a relative path. |
LOL now I've learned about the existence of a "dank" mono font...this is the PR that keeps on giving |
And create logo.png (using GIMP)
Now integrated! Thank you @rgbkrk and @choldgraf . I will announce this soon on twitter (when I have finished preparing the next bugfix release...) And regarding Jupyter Book's icon on pypi I have opened this PR: jupyter-book/jupyter-book#470. |
Here's the logo people seemed most in favor of in #260: