Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote strings in Rmd chunk options #385

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Nov 14, 2019

Strings in the metadata of code cells are quoted in the Rmd representation.
We escape R code in chunk options with #R_CODE#.
And use double quote by default for R strings.

Closes #383

…ation.

We escape R code in chunk options with `#R_CODE#`.
And use double quote by default for R strings.
@mwouts mwouts added this to the 1.3.0 milestone Nov 14, 2019
@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #385 into master will decrease coverage by 0.01%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
- Coverage   99.06%   99.04%   -0.02%     
==========================================
  Files          75       75              
  Lines        7455     7470      +15     
==========================================
+ Hits         7385     7399      +14     
- Misses         70       71       +1
Impacted Files Coverage Δ
jupytext/cell_to_text.py 97.29% <ø> (-0.03%) ⬇️
tests/test_cell_metadata.py 100% <ø> (ø) ⬆️
tests/test_read_simple_rmd.py 100% <100%> (ø) ⬆️
jupytext/cell_metadata.py 96.67% <88.88%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a04f548...bfef459. Read the comment docs.

@mwouts mwouts merged commit 4c78df0 into master Nov 14, 2019
@mwouts mwouts deleted the rmd_metadata_quote_strings branch November 14, 2019 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown conversion: metadata conversion issue
1 participant