Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.1 #219

Merged
merged 6 commits into from
Apr 16, 2019
Merged

1.1.1 #219

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,15 @@
Release History
---------------

1.1.1 (2019-04-16)
++++++++++++++++++++++

**Improvements**

- Jupytext server extension leaves the contents manager unchanged when it is already a subclass of TextFileContentsManager (#218)
- The base class for TextFileContentsManager defaults to FileContentsManager when LargeFileManager is not available (#217)


1.1.0 (2019-04-14)
++++++++++++++++++++++

Expand Down
6 changes: 3 additions & 3 deletions jupytext/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ class TextFileContentsManager:
"""A class that raises the previous ImportError"""
err = err

def __init__(self):
def __init__(self, parent=None, log=None): # noqa
raise self.err


def load_jupyter_server_extension(app): # pragma: no cover
"""Use Jupytext's contents manager"""
if app.contents_manager_class == TextFileContentsManager:
if isinstance(app.contents_manager_class, TextFileContentsManager):
app.log.info("[Jupytext Server Extension] NotebookApp.contents_manager_class is "
"jupytext.TextFileContentsManager already - OK")
"(a subclass of) jupytext.TextFileContentsManager already - OK")
return

# The server extension call is too late!
Expand Down
7 changes: 6 additions & 1 deletion jupytext/contentsmanager.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@
except ImportError:
pass

from notebook.services.contents.largefilemanager import LargeFileManager
try:
from notebook.services.contents.largefilemanager import LargeFileManager
except ImportError:
# Older versions of notebook do not have the LargeFileManager #217
from notebook.services.contents.filemanager import FileContentsManager as LargeFileManager

from jupyter_client.kernelspec import find_kernel_specs, get_kernel_spec

from .jupytext import reads, writes, create_prefix_dir
Expand Down
2 changes: 1 addition & 1 deletion jupytext/version.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
"""Jupytext's version number"""

__version__ = '1.1.0'
__version__ = '1.1.1'