Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1281 pre-commit fails with log.showsignature=True #1283

Closed
wants to merge 2 commits into from

Conversation

jlec
Copy link
Contributor

@jlec jlec commented Dec 7, 2024

Fixes #1281 by skipping the
signature in the log output

Fixes mwouts#1281 by skipping the
signature in the log output
Copy link

github-actions bot commented Dec 7, 2024

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/jlec/jupytext.git@main

(this requires nodejs, see more at Developing Jupytext)

@mwouts
Copy link
Owner

mwouts commented Dec 7, 2024

Thank you @jlec for looking into this!

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.03%. Comparing base (b74f5ce) to head (dfaca5b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1283      +/-   ##
==========================================
- Coverage   97.05%   97.03%   -0.03%     
==========================================
  Files          29       29              
  Lines        4479     4479              
==========================================
- Hits         4347     4346       -1     
- Misses        132      133       +1     
Flag Coverage Δ
external ?
functional ?
integration ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwouts
Copy link
Owner

mwouts commented Dec 15, 2024

Thanks @jlec for this PR! I have rebased this branch and removed the formatting change, and moved the result at #1295 which I will merge instead, but the commit remains yours. Thanks!

@mwouts mwouts closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre-commit hook fails with log.showsignature=True
2 participants