Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language support for Lua #1252

Merged
merged 2 commits into from
Jun 30, 2024
Merged

Add language support for Lua #1252

merged 2 commits into from
Jun 30, 2024

Conversation

erentar
Copy link
Contributor

@erentar erentar commented Jun 30, 2024

I have tried my best in following the instructions however was unable to get pip install -e '.[dev]' to work.

I would be thankful if someone helped me out by providing a dockerfile such that i can test it in a reproducible environment

Copy link

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/erentar/jupytext.git@testing

(this requires nodejs, see more at Developing Jupytext)

@mwouts
Copy link
Owner

mwouts commented Jun 30, 2024

Hi @erentar , thank you for making this PR! I am sorry that I can't provide a dockerfile, but I can provide conda instructions, see here: https://github.com/mwouts/jupytext/blob/main/docs/developing.md#install-and-develop-jupytext-locally

If you prefer I can also take your PR from here. Thanks!

@erentar
Copy link
Contributor Author

erentar commented Jun 30, 2024

@mwouts Please take over.
I cannot get pytest to work.

erentar and others added 2 commits June 30, 2024 22:07
Plus, remove the final space in markdown cells that
is not stable in round trips with MyST notebooks
@mwouts
Copy link
Owner

mwouts commented Jun 30, 2024

@mwouts Please take over. I cannot get pytest to work.

No problem! I'll get this done, and we will have the Lua support in the next release. Thank you for your contribution!

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (42a48e8) to head (bc8c4a8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1252   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files          29       29           
  Lines        4468     4468           
=======================================
  Hits         4367     4367           
  Misses        101      101           
Flag Coverage Δ
external 75.14% <ø> (+0.09%) ⬆️
functional 88.52% <ø> (ø)
integration 77.28% <ø> (ø)
unit 66.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwouts mwouts merged commit a9131de into mwouts:main Jun 30, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants