-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes and improvements on frontend extension #1178
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1178 +/- ##
==========================================
+ Coverage 96.74% 97.73% +0.98%
==========================================
Files 29 29
Lines 4456 4456
==========================================
+ Hits 4311 4355 +44
+ Misses 145 101 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @mahendrapaipuri , thank you for being back to this! Well, if I can request a few more changes, this is what I think we could do:
BTW I have released a RC as of yesterday: https://pypi.org/project/jupytext/1.16.0rc0/. So far everything works great! I plan to do the actual release over the next week-end if that is fine with you. |
I see that you would like to have the legacy UI. I thought having a dedicated Jupytext menu can improve the visibility accessibility. I agree moving New Text Notebook sub-menu under
I agree that introductory paragraph has clear information. But I tend to agree with @parmentelat as well as impatient users do not tend to read dense text (that includes me. hahah!). Unfortunately, we cannot really format the text to split in multiple lines, so, I tried to modify it to make it an easy read. What do you think? About the kernel variants, we do iterate over kernels and and we only use languages to get necessary metadata of kernel. So, if a user installs two variants of bash kernel, Jupytext menu will add both variants although both use shell language. Does it make sense? But I would trust you more on wording than myself (living in France does not help my English. Hahah!).
This is a good idea. We just need to add link checker on md files in CI to ensure we do not have any broken links when we rename UI test files.
Yes, this is taken care of.
That's great news. Congrats!! Once we agree, the changes the changes we are talking about should not take too much time. I can quickly update the PR for you to review. |
I gave a quick try with commit 1634da2 I agree that having the 'New Text Notebook' submenu in the File submenu right under New would be a better fit, as this is the place where people will look first; the rest of the Jupytext submenu is fine like it is now; this is in an ideal world, if it's too complex to implement the current setup is fine too :) I also agree with @mwouts that the ability to configure the 'Category' in settings brings no added value and we should get rid of it (or else, at least mention this is about the launcher entry) apart from that the settings pane is fine now, shorter to read, and I like that the warning on reloading comes last thanks a lot again @mahendrapaipuri for your patient work :) |
Alrighty! Cheers @parmentelat for testing the patch. Here are the latest changes
@mwouts @parmentelat Let me know what do you think!! |
yes !! that looks just perfect to me :) all that remains now - food for another time I mean ;-) would be to have the 'right' kernel selected by default as far as I am concerned we are a go 👍 |
Awesome! Thank you both again. I might not have much time for the rest of this week but this is really promising.
Oh that's an interesting point! In the menu we just use the language and extension, is this correct? Imagine that I have 12 Python kernels, I'd prefer not to get 12 entries for Python percent notebooks? (I think I saw just one when I tested).
Provided that my understanding above is correct, I would say that we do not even need to mention that. Most users will only have Python installed. And the other ones will have noticed that their favourite language is already available in the New Text Notebook menu. Thanks for updating the docs too, I like the automated screenshots!! |
Oh, yes! You are right!! Adding all available kernel variants was my first implementation and then after our discussions we have changed it to pick up kernel languages. So, I was wrong in my previous comment. If there are multiple kernels with same language, only the last one that appears in
Implemented this change in the latest commit. New additions:
|
Thank you again @mahendrapaipuri ! Yep the settings page will be even lighter this way, and still as useful. I have been thinking more about the location of the Jupytext Menu, and yes I am afraid I do miss the previous location (everything under File). My arguments for asking that are the following:
Happy to chat more about that! And looking forward to integrating this final touch!! |
* See [discussion](mwouts#1178 (comment)) Signed-off-by: mahendrapaipuri <[email protected]>
Agree, this is a valid argument.
Alright! I see what you mean. I tried to redo the menu items like in the legacy notebook extension. Let me know what do you think. You can check snapshots for new UI of the menu. |
* See [discussion](mwouts#1178 (comment)) Signed-off-by: mahendrapaipuri <[email protected]>
7a5d369
to
bf3784e
Compare
* See [discussion](mwouts#1178 (comment)) Signed-off-by: mahendrapaipuri <[email protected]>
bf3784e
to
f3b42b7
Compare
* See [discussion](mwouts#1178 (comment)) Signed-off-by: mahendrapaipuri <[email protected]>
f3b42b7
to
bf9eb71
Compare
Thank you for making this pull request. Did you know? You can try it on Binder: or . Also, the version of Jupytext developed in this PR can be installed with
(this requires |
Hey @mahendrapaipuri , sorry for the repeated updates, I am trying to get the comment PR action to work on forks, and it's not obvious 😄 I've had to use (I have opened thollander/actions-comment-pull-request#324) |
@mwouts You can use Check jupyterlab-gitlab repo on how it is being done. Here it is in action |
That's really impressive @mahendrapaipuri , you have the answer to everything!! Thanks 🙏 |
* See [discussion](mwouts#1178 (comment)) Signed-off-by: mahendrapaipuri <[email protected]>
bf9eb71
to
5fcfba3
Compare
Signed-off-by: mahendrapaipuri <[email protected]>
Signed-off-by: mahendrapaipuri <[email protected]>
Signed-off-by: mahendrapaipuri <[email protected]>
* Remove Category settings option Signed-off-by: mahendrapaipuri <[email protected]>
* Save full page screenshot so that we can use them in docs Signed-off-by: mahendrapaipuri <[email protected]>
Signed-off-by: mahendrapaipuri <[email protected]>
Signed-off-by: mahendrapaipuri <[email protected]>
Signed-off-by: mahendrapaipuri <[email protected]>
* Titles are already self explanatory Signed-off-by: mahendrapaipuri <[email protected]>
* Install Calysto bash kernel for UI tests * To ensure non standard kernels are working as well Signed-off-by: mahendrapaipuri <[email protected]>
* Avoid using kernelspec display names Signed-off-by: mahendrapaipuri <[email protected]>
Signed-off-by: mahendrapaipuri <[email protected]>
Signed-off-by: mahendrapaipuri <[email protected]>
* See [discussion](mwouts#1178 (comment)) Signed-off-by: mahendrapaipuri <[email protected]>
Signed-off-by: mahendrapaipuri <[email protected]>
5fcfba3
to
60ab3ee
Compare
Great work again! Thank you @mahendrapaipuri . |
This is follow up of #1163 that mainly attempts to fix remarks made here.
@parmentelat @mwouts Do you think settings page has better readability now?
The thing is Settings use rjsf behind the scenes and we cannot use text formatting like bold, italic, etc. Even if we use HTML tags, they will be escaped and rendered literally. So, I used a
null
JSON type to show message about browser refresh at the end in a separate line.@mwouts Before we merge this, we need to update the documentation unless you are working on it. I can update the screenshots and basic documentation of extension and maybe later you can expand on it. What do you think? But before its better we agree on settings UI.