-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore the codecov comments on PRs #1173
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
71a4c66
Test against jupyter-server!=2.11
mwouts a7a16f3
Remove the experimental entries in the matrix
mwouts daf543f
Use a default shell
mwouts c84521c
Use an explicit coverage file
mwouts b05b0b8
Allow coverage fluctuations up to 0.2%
mwouts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,26 +10,17 @@ concurrency: | |
|
||
jobs: | ||
test-pip: | ||
continue-on-error: ${{ matrix.experimental || false }} | ||
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
python-version: [ "3.8", "3.9", "3.10", "3.11" ] | ||
markdown-it-py-version: ["~=2.0"] | ||
python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12-dev"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Python 3.12 has been officially out. Should be included soon. |
||
markdown-it-py-version: ["~=3.0"] | ||
include: | ||
- python-version: "3.12-dev" | ||
experimental: true | ||
- python-version: "3.13-dev" | ||
experimental: true | ||
- python-version: "3.x" | ||
markdown-it-py-version: "" | ||
- python-version: "3.x" | ||
markdown-it-py-version: "~=3.0" | ||
markdown-it-py-version: "~=2.0" | ||
- python-version: "3.x" | ||
markdown-it-py-version: "~=4.0" | ||
experimental: true | ||
markdown-it-py-version: "" | ||
- python-version: "3.x" | ||
no_kernel: true | ||
- python-version: "3.x" | ||
|
@@ -74,3 +65,6 @@ jobs: | |
|
||
- name: Upload coverage | ||
uses: codecov/codecov-action@v3 | ||
with: | ||
fail_ci_if_error: true | ||
verbose: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fail_ci_if_error
has no effect here because this step is not triggered if the test step failed. You can addif: always()
if you do want it to upload failed code coverage.