Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: update jupyterlab requirements for linked jupytext not… #1032

Merged
merged 2 commits into from
Jan 15, 2023

Conversation

nthiery
Copy link
Contributor

@nthiery nthiery commented Jan 11, 2023

@mwouts
Copy link
Owner

mwouts commented Jan 15, 2023

Thank you @nthiery for making this possible!

By the way, what would you think of simplifying "jupyterlab>=3.6.0 or jupyterlab>=4.0.0a16" into just "jupyterlab>=3.6.0" in this PR?

@nthiery
Copy link
Contributor Author

nthiery commented Jan 15, 2023

Yeah, I pondered about it; the double formulation is indeed confusing if the reader
does not have in mind that there are two distinct lines and versions don't form a
total order.

The simplified formulation >= 3.6 is making an assumption: that the user is not
using a quite old jupyterlab 4 prerelease. Presumably it is fine to make
this assumption, taking for granted that a someone using such an old
prerelease must be a power user with very specific needs that will know
what they are doing.

@mwouts
Copy link
Owner

mwouts commented Jan 15, 2023

Yea exactly! I think it has been a while since that feature is available in the version 4dev, so this should be a safe assumption in practice 😀

@mwouts mwouts merged commit aae7c64 into mwouts:main Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants