Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paired notebooks dont work when notebook name contains a dot #87

Closed
mwouts opened this issue Sep 21, 2018 · 1 comment
Closed

Paired notebooks dont work when notebook name contains a dot #87

mwouts opened this issue Sep 21, 2018 · 1 comment
Assignees

Comments

@mwouts
Copy link
Owner

mwouts commented Sep 21, 2018

Reported by @mppaskov at #70

Not sure if this is related but I had a notebook named 1.Some Notebook.ipynb and it was not exporting automatically to .py. Even after manually exporting the notebook with the command line it would not sync. Was able to fix this by renaming the notebook Some Notebook.ipynb.

The bug occurs because the extension of the initial notebook is recognized as .Some Notebook.ipynb, which is not associated to .py (unless the user sets
"jupytext_formats":"Some Notebook.ipynb,py" , which we clearly do not want!)

@mwouts
Copy link
Owner Author

mwouts commented Sep 21, 2018

This is caused by mwouts/nbsrc#5: in case the user has a script with the same name as the notebook, he may want to save the text of the notebook to a notebook.nb.py file with extension nb.py. Possibly we want to remove that possibility to make practice simpler!

@mwouts mwouts closed this as completed Sep 30, 2018
@mwouts mwouts mentioned this issue Oct 10, 2018
mwouts added a commit that referenced this issue Dec 13, 2018
#87 #138 extension for file name with dot is simply the extension, unless the intermediate prefix is one of lgt/pct/spx/nb
Fixes #138
mwouts added a commit that referenced this issue Jan 14, 2019
#87 #138 extension for file name with dot is simply the extension, unless the intermediate prefix is one of lgt/pct/spx/nb
Fixes #138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant