-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade myst-parser dependency to 0.12.x #591
Comments
Heya, yeh at some point in the next week or 2, I want to do a 2nd "parse at the parser" here, taking into account our discussion in executablebooks/MyST-NB#214 and looking to remove the myst-parser dependancy (maybe just using the underlying markdown-it-py dependency) |
That sounds great! Although I don't want to cause you lots of work. Personally I was thinking of just making Jupytext 1.6.0 depend on FYI I recently merged in master a commit that ensures that MyST files are recognized as such even when |
Yeh the only issue with that, is that it now has a direct dependency on
That's great thanks 😄 |
FYI, MyST-NB (and thus jupyter-book) now supports using any jupytext conversion 😄 (see https://myst-nb.readthedocs.io/en/latest/examples/custom-formats.html) When writing this page,
````md
```{python echo=TRUE}
import pandas as pd
series = pd.Series({'A':1, 'B':3, 'C':2})
pd.DataFrame({"Columne A": series})
```
```` However, this ended up messing up the jupytext conversion, with the code-chunk after it no longer being identified as a code cell. If so, this leads me on to another suggestion; that if markdown-it-py is going to be a dependency of jupytext, then it can be used to do some of the required Markdown parsing, rather than having more "bespoke" parsing functions. Line 226 in b8c2a1c
Could take a bit of work though, so I wouldn't expect this any time soon 😉 |
Hello Chris,
Yes, that's right, the parsing system is Jupytext is not very elaborate. When I wrote it I was not aware of the possibility of using more than three backticks... Of course we could consider switching to Regarding the version of
|
I will make a PR in the next day or 2 |
See also #589 . Cc @chrisjsewell .
The text was updated successfully, but these errors were encountered: