Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading jupytext support #236

Closed
parmentelat opened this issue Aug 29, 2020 · 8 comments
Closed

Upgrading jupytext support #236

parmentelat opened this issue Aug 29, 2020 · 8 comments
Labels
enhancement New feature or request upstream This issue requires an upstream dependency fix

Comments

@parmentelat
Copy link

Hi; I just rebuilt my docker images and am facing a regression:

with most recent release

$ pip show myst-parser
Name: myst-parser
Version: 0.12.6
...

$ jupytext --to py:percent 1-99-quiz-python.md 
[jupytext] Reading 1-99-quiz-python.md
/opt/conda/lib/python3.8/site-packages/jupytext/myst.py:76: UserWarning: myst-parse failed unexpectedly: default_parser() got an unexpected keyword argument 'disable_syntax'
  warnings.warn("myst-parse failed unexpectedly: {}".format(err))
[jupytext] Writing 1-99-quiz-python.py in format py:percent

going back to 0.11

$ pip install myst-parser==0.11
<...>
$ jupytext --to py:percent 1-99-quiz-python.md 
[jupytext] Reading 1-99-quiz-python.md
[jupytext] Writing 1-99-quiz-python.py in format py:percent (destination file replaced)

the sample notebook can be found here
https://raw.githubusercontent.com/ue12/python-numerique/8c3d0afed6d449f88111184401b9505e05c05327/notebooks/1-99-quiz-python.md

this has rather devastating consequences to me, as my students can no longer see the material as notebooks but as a botched md instead; please let me know what is happening here; looks like something on your end, is that correct ?

@parmentelat parmentelat added the bug Something isn't working label Aug 29, 2020
@welcome
Copy link

welcome bot commented Aug 29, 2020

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@chrisjsewell
Copy link
Member

chrisjsewell commented Aug 29, 2020

Yeh this is a known issue that I am about to fix today mwouts/jupytext#591

@chrisjsewell
Copy link
Member

The current "fix" is to use an earlier version of jupytext

@parmentelat
Copy link
Author

fair enough

have you got a sense about when all this will make it on pypi, so that a regular build (i.e. with pip using the latest releases) will work again ? if it's a matter of days, it's maybe simpler for me to just wait instead of pinning/unpinning version numbers all over the place ;-)

otherwise, are you positive it's jupytext that needs to have its version pinned down ? my experiment was only about the version of myst-parser - otoh I haven't recorded the version of jupytext in both cases...
if so, what version of jupytext should be used ?

thanks for the prompt answer !

@chrisjsewell
Copy link
Member

Well yeh you need to have myst-parser 0.8.
But hopefully, it will be a matter of days 🤞

(There is a warning about this in https://myst-nb.readthedocs.io/en/latest/examples/custom-formats.html#using-jupytext)

@chrisjsewell
Copy link
Member

chrisjsewell commented Aug 30, 2020

See mwouts/jupytext#599

@chrisjsewell chrisjsewell changed the title I came across something that looks like a regression to me Upgrading jupytext support Aug 30, 2020
@chrisjsewell chrisjsewell added enhancement New feature or request upstream This issue requires an upstream dependency fix and removed bug Something isn't working labels Aug 30, 2020
@chrisjsewell
Copy link
Member

chrisjsewell commented Aug 31, 2020

A release candidate is now available here:

pip install jupytext==1.6.0rc0

😀

@parmentelat
Copy link
Author

much appreciated ! please let us know when it makes it to release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upstream This issue requires an upstream dependency fix
Projects
None yet
Development

No branches or pull requests

2 participants