Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a logo for jupytext #423

Merged
merged 3 commits into from
Jan 26, 2020
Merged

create a logo for jupytext #423

merged 3 commits into from
Jan 26, 2020

Conversation

rgbkrk
Copy link
Contributor

@rgbkrk rgbkrk commented Jan 23, 2020

Here's the logo people seemed most in favor of in #260:

image

@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #423 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   98.93%   98.91%   -0.03%     
==========================================
  Files          75       75              
  Lines        7608     7448     -160     
==========================================
- Hits         7527     7367     -160     
  Misses         81       81
Impacted Files Coverage Δ
tests/test_pep8.py 98.36% <0%> (-0.03%) ⬇️
tests/test_cli.py 100% <0%> (ø) ⬆️
tests/test_black.py 100% <0%> (ø) ⬆️
tests/test_active_cells.py 100% <0%> (ø) ⬆️
tests/test_knitr_spin.py 100% <0%> (ø) ⬆️
tests/test_compare.py 100% <0%> (ø) ⬆️
tests/test_ipynb_to_rmd.py 100% <0%> (ø) ⬆️
tests/conftest.py 100% <0%> (ø) ⬆️
tests/test_metadata_filter.py 100% <0%> (ø) ⬆️
tests/test_hide_remove_input_outputs_rmarkdown.py 100% <0%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5328a7d...7e3d2b3. Read the comment docs.

@choldgraf
Copy link
Contributor

Maybe this can come with a quick note in the docs for what font the logo uses? Maybe that's unnecessary, but I've found stuff like that is helpful in order to avoid having to reverse-engineer the logo at some point in the future if need be...

@mwouts
Copy link
Owner

mwouts commented Jan 23, 2020

Thank you so much @rgbkrk !
I'll integrate this over the week-end.

In addition to the svg file, I'd like to

  • Add the logo to the README, and make sure it works well with pypi. Papermill's logo works fine there, but not Jupyter Book's one, I'll try find out why and PR the Jupyter Book project to fix that...
  • Add the logo to readthedocs

@choldgraf
Copy link
Contributor

I don't know why but for some reason open source logo design is one of my favorite kinds of open source contributions to see :-)

@rgbkrk
Copy link
Contributor Author

rgbkrk commented Jan 23, 2020

The font is Dank Mono. Happy to help.

When you link in the readme you'll probably want to point directly at a full github URL pointing to master rather than a relative path.

@choldgraf
Copy link
Contributor

LOL now I've learned about the existence of a "dank" mono font...this is the PR that keeps on giving

@mwouts mwouts merged commit 3a6512d into mwouts:master Jan 26, 2020
@mwouts
Copy link
Owner

mwouts commented Jan 26, 2020

Now integrated! Thank you @rgbkrk and @choldgraf . I will announce this soon on twitter (when I have finished preparing the next bugfix release...)

And regarding Jupyter Book's icon on pypi I have opened this PR: jupyter-book/jupyter-book#470.

@mwouts mwouts added this to the 1.3.3 milestone Jan 26, 2020
@rgbkrk rgbkrk deleted the diff-logo branch January 27, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants