Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument --test fails if run on different jupytext versions #414

Closed
kernc opened this issue Jan 8, 2020 · 1 comment · Fixed by #420
Closed

Argument --test fails if run on different jupytext versions #414

kernc opened this issue Jan 8, 2020 · 1 comment · Fixed by #420
Milestone

Comments

@kernc
Copy link
Contributor

kernc commented Jan 8, 2020

jupytext --test --to ipynb FILE.py fails with:

[jupytext] Reading FILE.py
--- expected
+++ actual
@@ -5,7 +5,7 @@
 #       extension: .py
 #       format_name: light
 #       format_version: '1.5'
-#       jupytext_version: 1.3.0
+#       jupytext_version: 1.3.2
 #   kernelspec:
 #     display_name: Python 3
 #     language: python

I suggest to add jupytext_version (and maybe even format_version) to _IGNORE_CELL_METADATA (or appropriate), because those lines will differ on different jupytext invocations but might otherwise not influence the converted output in any way.

They remain covered by --test-strict.

@mwouts
Copy link
Owner

mwouts commented Jan 11, 2020

Hello @kernc , yes I agree, this is among the expected changes in a round-trip. I will fix this in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants