Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to FileContentsManager to support older notebook versions #217

Closed
153957 opened this issue Apr 16, 2019 · 4 comments
Closed

Fallback to FileContentsManager to support older notebook versions #217

153957 opened this issue Apr 16, 2019 · 4 comments
Milestone

Comments

@153957
Copy link
Contributor

153957 commented Apr 16, 2019

Since jupytext 1.1.0 support for notebook 4.4.1 is broken. That is since this fix: #210 ( 9d9b1e8 ), because that imported module does not exist in notebook 4.4.1. Could a fallback (in case of ImportError) to FileContentsManager be added? or at least made explicit that older versions of notebook are no longer supported.

@mwouts
Copy link
Owner

mwouts commented Apr 16, 2019

Hello @153957 , thanks for letting me know. Indeed we could implement a fallback. I will give it a try soon.

@153957
Copy link
Contributor Author

153957 commented Apr 16, 2019

In the mean time I have been upgrading the code where I encountered this problem to the newer notebook 5.x.x, so it is no longer an issue for me. However, a fix and/or a clear supported version list in the readme would still be useful.

@mwouts
Copy link
Owner

mwouts commented Apr 16, 2019

Sure! Upgrading notebook is a solution. Still, as you mention, catching the import error should be fairly easy, and you may not be the only person finding this issue, so I do prefer to provide a fallback...

@mwouts mwouts added this to the 1.1.1 milestone Apr 16, 2019
@mwouts mwouts mentioned this issue Apr 16, 2019
@mwouts
Copy link
Owner

mwouts commented Apr 16, 2019

This is included in the latest release:

pip install jupytext==1.1.1

@mwouts mwouts closed this as completed Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants