Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with tfoot not working in (Jupyter) HTML export #332

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Nov 2, 2024

Prior to this, the table footer would go outside of the table when exporting the notebook to HTML

Closes #331

Prior to this, the table footer would go outside of the table when exporting the notebook to HTML
Copy link

github-actions bot commented Nov 2, 2024

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab.

Also, the version of ITables developed in this PR can be installed with pip:

pip install git+https://github.com/mwouts/itables.git@issue_331_fix_tfoot

(this requires nodejs, see more at Developing ITables)

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (57cf995) to head (9a92928).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   94.69%   94.76%   +0.07%     
==========================================
  Files          24       24              
  Lines        1281     1280       -1     
==========================================
  Hits         1213     1213              
+ Misses         68       67       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwouts mwouts merged commit f9ce618 into main Nov 2, 2024
15 checks passed
@mwouts mwouts deleted the issue_331_fix_tfoot branch November 2, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exported HTML File doesn't contain column filter when "footer" is chosen
2 participants