Update Deflate.java #692
Merged
Update Deflate.java #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1309,7 +1309,7 @@ int longest_match(int cur_match) { | |||
| && window[++scan] == window[++match] && window[++scan] == window[++match] | |||
| && scan < strend); | |||
|
|
|||
| len = MAX_MATCH - strend - scan; | |||
| len = MAX_MATCH - (strend - scan); | |||
There was a problem hiding this comment.
Can you add a comment here explaining that the parenthesis are required?
Otherwise someone may in the future believe they are unnecessary and remove them.
There was a problem hiding this comment.
No problem - I added a comment, based on my best understanding of the longest_match method.
There was a problem hiding this comment.
Can you please run mvn formatter:format so this comment is formatted correctly?
There was a problem hiding this comment.
Can you pull the third line of this comment up to the second line so that it doesn't appear to awkward?
I.e.
// len here is set to MAX_MATCH minus (strend minus scan, i.e. the distance between scan and
// strend) to ensure that best_len is set to the best possible length to lookahead
|
norrisjeremy
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates back to match the logic from jzlib's Deflate class to set len, minus jzlib's unnecessary cast to (int)
len = MAX_MATCH - (int)(strend - scan);All tests are passing. I did not add a test to the codebase, but with a 105mb XML file, compression level 6
before this update:
after this update: