Allow ssh-agent keys that are unsupported #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norrisjeremy
force-pushed
the
20210906
branch
from
18ccde3 to
d658f59
Compare
…use of missing support for the signature algorithm.
norrisjeremy
force-pushed
the
20210906
branch
2 times, most recently
from
a45f0ac to
4341d30
Compare
…Bouncy Castle: - ssh-ed25519 - ssh-ed448 - curve25519-sha256 - [email protected] - curve448-sha512 - [email protected]
norrisjeremy
force-pushed
the
20210906
branch
from
4341d30 to
a249d10
Compare
|
Thats awesome! I also had the bouncycastle fallback on my list, but now you have already done it. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI, allowing usage of ssh-agent keys allows using ssh-ed25519 from Java versions < 15, since the signature generation process is delegated to the ssh-agent process and does not rely upon Ed25519 support within Java itself.
Also, the ssh-agent integration tests can only be run from Linux, since it relies on sharing a bind mount between the host and container running the ssh-agent process, and it doesn't seem possible to share the ssh-agent's unix domain socket through this bind mount on macOS (and I assume Windows as well).
FYI, the Bouncy Castle addition is completely optional: JSch will still function without it being present in the classpath, albeit without supporting the above mentioned algorithms on older Java releases. This should help address some issues that have been raised by users asking why we don't support these algorithms on older Java releases: all the user has to do is add the
bcprov-jdk15onjar-file to their classpath to gain support.