Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.2.19 changes #605

Merged
merged 3 commits into from
Aug 6, 2024
Merged

0.2.19 changes #605

merged 3 commits into from
Aug 6, 2024

Conversation

norrisjeremy
Copy link
Contributor

@norrisjeremy norrisjeremy commented Jul 23, 2024 •
edited
Loading

@norrisjeremy
Copy link
Contributor Author

SonarCloud doesn't like this line, since it performs a compound addition on a volatile field.
In practice, I don't believe it actually is an issue, since at this point in time, JSch should only be accessing the kex_start_time field in a single-threaded fashion, as this is early in the connect() method before any threads are created.
Therefore I'm not sure if it's worthwhile trying to quiesce SonarCloud by changing the kex_start_time field into an AtomicLong.

@norrisjeremy norrisjeremy mentioned this pull request Jul 23, 2024
Open
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mwiede
Copy link
Owner

mwiede commented Jul 29, 2024

can you try adding @SuppressWarnings("java:S3078") at class or method level?

@mwiede mwiede merged commit 4be7e28 into mwiede:master Aug 6, 2024
7 checks passed
@norrisjeremy norrisjeremy deleted the 20240723 branch August 29, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@norrisjeremy @mwiede