Improve error handling in InputStream.close() for SFTP channels #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norrisjeremy
suggested changes
May 24, 2023
| } catch (Exception e) { | ||
| throw new IOException("error"); | ||
| throw new IOException(e.toString(), e); |
There was a problem hiding this comment.
I would suggest doing it like this instead:
if (e instanceof IOException)
throw (IOException) e;
throw new IOException(e.toString(), e);
There was a problem hiding this comment.
I copied this particular code block from another part of the same file (line 826).
Sonar proposes to do this the way I did this
https://rules.sonarsource.com/java/RSPEC-1193
In the end the code is equivalent, so if you care about it, I can also change the pull request.
There was a problem hiding this comment.
Ok, I see that now, apologies.
norrisjeremy
approved these changes
May 25, 2023
| } catch (Exception e) { | ||
| throw new IOException("error"); | ||
| throw new IOException(e.toString(), e); |
There was a problem hiding this comment.
Ok, I see that now, apologies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330