adds ability to ignore git dependencies #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweststrate
requested changes
Jun 24, 2021
| @@ -108,13 +109,17 @@ async function libraryHasChanged(name, libDir, targetDir, hashStore) { | |||
|
|
|||
| async function findFiles(libDir, targetDir) { | |||
| const ignore = ["**/*", "!node_modules", "!.git"] | |||
| const { argv: { ignoreGit } } = yargs | |||
There was a problem hiding this comment.
Could you register the option in cli.js instead of inline in this function? Otherwise the option would be shown in the help etc.
| // TODO: use resolved paths here | ||
| if (targetDir.indexOf(libDir) === 0) { | ||
| // The target dir is in the lib directory, make sure that path is excluded | ||
| ignore.push("!" + targetDir.substr(libDir.length + 1).split(path.sep)[0]) | ||
| } | ||
| const files = await globby(ignore, { | ||
| gitignore: true, | ||
| gitignore: !ignoreGit, |
There was a problem hiding this comment.
If I read this correctly, I'm confused by the name now, ignoreGit is now off by default, which turns the option to globby on. But if you pass the ignoreGit flag, the gitignore flag will not be applied. Could you either find a better name, or remove the negation and default to true?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.